ci: Fix submit workflow #35
Conversation
| @@ -55,6 +55,7 @@ jobs: | |||
| with: | |||
| path: .output/*.zip | |||
| if-no-files-found: error | |||
| include-hidden-files: true | |||
There was a problem hiding this comment.
Ah yeah, haven't used this since this action started ignoring hidden files. Thanks!
.github/workflows/submit.yml
Outdated
| run: pnpx changelogen@latest gh release ${{ steps.version.outputs.newVersion }} --token ${{ github.token }} | ||
| run: gh release create v${{ steps.version.outputs.newVersion }} .output/*.zip -F CHANGELOG.md | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
changelogen gh release just syncs the changelog with the latest release, it doesn't regenerate the changelog or anything like that. So these are doing almost the same thing.
The -F CHANGELOG.md is using your entire changelog as your release notes... Which I don't think you want?
I don't know why github.token worked for me and not for you, weird. You can replace it with secrets.GITHUB_TOKEN like you did, that's fine.
And uploading the zip files as artifacts would be a good idea...
There was a problem hiding this comment.
Sorry, I was confused with changelogen gh release command, not realizing it's a subcommand of changelogen package. So, it might be working correctly.
Hi! I was using your workflow as an example and ran into some issues.
.outputlisted in.gitignoreghcommand didn't work for me.changelogenagain if we have CHANGELOG.md, just pass it toghcommand.env.